Skip to content

Integration of Clarity compliance mechanism #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

NucleonGodX
Copy link
Contributor

@NucleonGodX NucleonGodX commented Jun 27, 2025

Ref: #1678

This pull request adds the clarity_compliance_alert field to the UI and to check-compliance commands, positioning it alongside the existing compliance alert section. This integrates structure made in #1689, and is intended as a follow-up to that work.

Once #1689 is merged, I will rebase this branch onto the main branch to ensure a smooth integration.

@NucleonGodX
Copy link
Contributor Author

How it looks in UI:
image
image
image

How it looks using in commands:
image

@tdruez
Copy link
Contributor

tdruez commented Jun 30, 2025

@NucleonGodX You can now merge "main" in this branch following the merge of #1689

Also, instead of a new panel, let's start simply with a new line in the "Compliance Alerts" panel:
Screenshot 2025-06-30 at 13 22 36

Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
@NucleonGodX NucleonGodX force-pushed the clarity-compliance-integration branch from 064d2d2 to a22533c Compare June 30, 2025 13:15
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
@NucleonGodX
Copy link
Contributor Author

Thanks @tdruez , I've applied your suggestions.

Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Copy link
Contributor

@tdruez tdruez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with license_clarity_thresholds, use "license_clarity" everywhere (code and docs)
For example, instead of clarity_compliance_alert -> license_clarity_compliance_alert


def get_project_clarity_thresholds(project):
"""
Get clarity thresholds for a project, checking multiple sources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be precise about the "multiple sources"

Signed-off-by: NucleonGodX <racerpro41@gmail.com>
…compliance everywhere

Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants