-
Notifications
You must be signed in to change notification settings - Fork 109
Integration of Clarity compliance mechanism #1705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Integration of Clarity compliance mechanism #1705
Conversation
@NucleonGodX You can now merge "main" in this branch following the merge of #1689 Also, instead of a new panel, let's start simply with a new line in the "Compliance Alerts" panel: |
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
064d2d2
to
a22533c
Compare
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Thanks @tdruez , I've applied your suggestions. |
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with license_clarity_thresholds
, use "license_clarity" everywhere (code and docs)
For example, instead of clarity_compliance_alert
-> license_clarity_compliance_alert
scanpipe/pipes/license_clarity.py
Outdated
|
||
def get_project_clarity_thresholds(project): | ||
""" | ||
Get clarity thresholds for a project, checking multiple sources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be precise about the "multiple sources"
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
…compliance everywhere Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Ref: #1678
This pull request adds the clarity_compliance_alert field to the UI and to check-compliance commands, positioning it alongside the existing compliance alert section. This integrates structure made in #1689, and is intended as a follow-up to that work.
Once #1689 is merged, I will rebase this branch onto the main branch to ensure a smooth integration.